Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docker-compose): use a separate image for each component #65

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

aabouzaid
Copy link
Member

@aabouzaid aabouzaid commented Jan 22, 2025

Task: https://github.com/camunda/distribution/issues/287
For Camunda 8.6 and 8.7, we still use a separate image/version for each component.

@aabouzaid aabouzaid self-assigned this Jan 22, 2025
@aabouzaid aabouzaid marked this pull request as ready for review January 22, 2025 11:54
Copy link

@hisImminence hisImminence left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -460,7 +460,7 @@ services:
RESTAPI_MAIL_FROM_ADDRESS: "noreply@example.com"
CAMUNDA_MODELER_CLUSTERS_0_ID: "local-zeebe"
CAMUNDA_MODELER_CLUSTERS_0_NAME: "Local Zeebe instance"
CAMUNDA_MODELER_CLUSTERS_0_VERSION: ${CAMUNDA_PLATFORM_VERSION}
CAMUNDA_MODELER_CLUSTERS_0_VERSION: ${CAMUNDA_ZEEBE_VERSION}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For my learning, why is modeler version = zeebe version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the Local Zeebe instance version.
Those vars are used to seed the Zeebe config in WM, so the user doesn't need to manually set up the Zeebe cluster info. So this is just a reference to Zeebe deployment.

@aabouzaid aabouzaid merged commit 30b5f59 into main Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants