Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: element templates engines integration #4831

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

jarekdanielak
Copy link
Contributor

Proposed Changes

Ensure cloud BPMN editor provides the up-to-date versions of the app and runtime platform to the element templates module.

More on the engines compatibility feature: bpmn-io/bpmn-js-element-templates#132

Closes #4760

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

…nes feature

We make sure current modeler version and runtime version is provided to the element templates module.

Closes #4760
@jarekdanielak jarekdanielak self-assigned this Feb 13, 2025
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 13, 2025
@jarekdanielak jarekdanielak requested review from koevskinikola and nikku and removed request for koevskinikola February 13, 2025 13:18
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great tests. Simple enough, given our existing test infrastructure 🙈

I verified that both tests are meaningful by commenting out this line and this line.

@jarekdanielak jarekdanielak merged commit 0c187c1 into main Feb 17, 2025
13 of 14 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 17, 2025
@jarekdanielak jarekdanielak deleted the templates-runtime-test branch February 17, 2025 09:24
@github-actions github-actions bot added this to the M86 milestone Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants