Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump form-js@1.11.3 #4647

Merged
merged 2 commits into from
Oct 30, 2024
Merged

deps: bump form-js@1.11.3 #4647

merged 2 commits into from
Oct 30, 2024

Conversation

vsgoulart
Copy link
Contributor

@vsgoulart vsgoulart commented Oct 30, 2024

Proposed Changes

Bump to form-js@1.11.3: changelog

Closes #4644

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@nikku
Copy link
Member

nikku commented Oct 30, 2024

CI fails, because styles can no longer be found. Anything else that we changed to break this?

@vsgoulart
Copy link
Contributor Author

CI fails, because styles can no longer be found. Anything else that we changed to break this?

@nikku No, the only fix I shipped was bpmn-io/form-js@9837135

Plus some build dep that was merged

I'll check why it's failing
image

@vsgoulart
Copy link
Contributor Author

@nikku Should be fixed now, I think the MacOS failure is not because of this PR, correct?

@nikku
Copy link
Member

nikku commented Oct 30, 2024

Correct, CI failure is unrelated to your PR.

@nikku
Copy link
Member

nikku commented Oct 30, 2024

General feedback on this: We should probably move the hint to a tooltip:

image

I already see tooltips used consistently in other places.

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, I could not break it. Thanks for the contribution 🌞

I stumbled upon the internally missing test coverage (bpmn-io/form-js@9837135#r148545446), but also that we do not use the tooltip for meta-hints (#4647 (comment)).

Both are non blocking for this merge.

@nikku nikku changed the base branch from develop to main October 30, 2024 11:43
@nikku nikku merged commit 62334b8 into main Oct 30, 2024
12 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Oct 30, 2024
@nikku nikku deleted the bump-form-js branch October 30, 2024 11:43
@github-actions github-actions bot added this to the M82 milestone Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Editor crashes when FEEL expression is created in the File Picker form element
2 participants