-
Notifications
You must be signed in to change notification settings - Fork 495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump form-js@1.11.3 #4647
Conversation
CI fails, because styles can no longer be found. Anything else that we changed to break this? |
@nikku No, the only fix I shipped was bpmn-io/form-js@9837135 Plus some build dep that was merged |
@nikku Should be fixed now, I think the MacOS failure is not because of this PR, correct? |
Correct, CI failure is unrelated to your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works, I could not break it. Thanks for the contribution 🌞
I stumbled upon the internally missing test coverage (bpmn-io/form-js@9837135#r148545446), but also that we do not use the tooltip for meta-hints (#4647 (comment)).
Both are non blocking for this merge.
Proposed Changes
Bump to
form-js@1.11.3
: changelogCloses #4644
Checklist
To ensure you provided everything we need to look at your PR:
@bpmn-io/sr
toolCloses {LINK_TO_ISSUE}
orRelated to {LINK_TO_ISSUE}