Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All Form break when array of documents used in 'documents preview' in 8.7 #4828

Closed
Szik opened this issue Feb 12, 2025 · 11 comments · Fixed by bpmn-io/form-js#1359
Closed

All Form break when array of documents used in 'documents preview' in 8.7 #4828

Szik opened this issue Feb 12, 2025 · 11 comments · Fixed by bpmn-io/form-js#1359
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Szik
Copy link

Szik commented Feb 12, 2025

Describe the bug

All Form (created and new forms) remain without elements in 'documents preview' in 8.7.
Likely this bug is present in 8.8 but was not tested yet.

Steps to reproduce

  1. create Form with 'document preview'
  2. under 'General' enter an array (such as '[doc]') in 'Document reference'
  3. reloading any Form will lead to no form elements being shown

Expected behavior

forms keep their normal function when entering using an array of documents.

Environment

  • OS: Linux
  • Camunda Modeler Version: 8.7.0-alpha4
  • Execution Platform: Camunda 8

Additional context

Bildschirmaufzeichnung.vom.12.02.2025.18.27.16.webm
@Szik Szik added the bug Something isn't working label Feb 12, 2025
@Szik Szik added this to the 8.7 milestone Feb 12, 2025
@nikku
Copy link
Member

nikku commented Feb 12, 2025

CC @camunda/hto-frontend, can you have a look?

@gbetances089
Copy link
Member

@camunda/hto-frontend did you have the time to look at this? is a bit urgent/release blocking here

@vsgoulart
Copy link
Contributor

@camunda/hto-frontend did you have the time to look at this? is a bit urgent/release blocking here

@gbetances089 No, because it wasn't mentioned it was a release blocker
Next time for form related things ping us on #ask-human-task-orchestration-team in Slack so it's faster

I'll take a look now

@gbetances089
Copy link
Member

Next time for form related things ping us on #ask-human-task-orchestration-team in Slack so it's faster

Ahh, gotcha, will bring this to the QA team too for awareness

@vsgoulart
Copy link
Contributor

vsgoulart commented Feb 13, 2025

I have a fix for it, I'm waiting for a review and clarification how to backport this to the web modeler

@nikku We will have to backport it to the desktop modeler, this happens there too

@nikku
Copy link
Member

nikku commented Feb 13, 2025

@nikku We will have to backport it to the desktop modeler, this happens there too

Backport or forward fix? Should be sufficient to release with v5.33 (the next Modeler release).

@vsgoulart
Copy link
Contributor

vsgoulart commented Feb 13, 2025

Backport or forward fix?

We're not sure yet. On one side this is quite a major bug since a user would not be able to open even a valid form after this bug happens on the other side the document preview has not been officially released yet. I'm syncing with @wollefitz on this Slack thread in case you want to join

@nikku
Copy link
Member

nikku commented Feb 13, 2025

document preview has not been officially released yet.

For Desktop Modeler this means forward fix. Let's aim to have it fully working with the next release. Great to see that we find these bugs now (rather than later).

@barmac
Copy link
Collaborator

barmac commented Feb 13, 2025

Since the document preview is not available in the current stable release, I'd rather not push for an early patch of the Desktop Modeler. As an alpha feature, it is expected to break.

Image

@vsgoulart
Copy link
Contributor

Just writing what I wrote on the release thread on Slack

We decided that since the document preview component hasn't been officially released yet we don't consider it a release blocker for SM we will merge the fix on Web Modeler main to make the fix available ASAP in SaaS but for the SM versions this will only be available on the next release

@vsgoulart vsgoulart self-assigned this Feb 13, 2025
@vsgoulart
Copy link
Contributor

@bpmn-io-tasks bpmn-io-tasks bot closed this as completed Feb 14, 2025
@nikku nikku modified the milestones: 8.7, M86 Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants