Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: DKG ammendments to include dynamic time_label integration #1494

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

waleedalzarooni
Copy link
Collaborator

Description

I have altered the add_node function to allow for cases where there is no time_label specified in the tag_name schema, however, the add_node function is called with a time_label argument. This amendment dynamically adds the time_label to the schema when the add_node function is called even when the schema doesn't originally include this label.

Motivation and Context

Provides more flexible usage for building dynamic knowledge graphs

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • [X ] I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • [ X] I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Wendong-Fan Wendong-Fan changed the title DKG ammendments to include dynamic time_label integration feat: DKG ammendments to include dynamic time_label integration Jan 23, 2025
@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Jan 23, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 21 milestone Jan 23, 2025
@NeilJohnson0930
Copy link
Collaborator

Hi Waleed, could you add some example tests for the new feature in examples/storages/nebular_graph.py when you get a chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants