Multiplayer #20
Multiplayer #20
Conversation
…into multiplayer
…into multiplayer
…Move script and into runtime and initialize windows for find server, sessions, and send data
…nd fetching sessions
Intrinsics can change every frame so we can't assume it's static. Have to log every frame.
|
Also, something is wrong with the CI? |
We haven't done the implementation for benchmarking with synchronous data sending right now, so pyright throws error with unused variables |
|
Let's ignore those lines for the unimplemented parts. |
python/.vscode/extensions.json
Outdated
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
I think we should only have the .vscode folder at the project root level.
There was a problem hiding this comment.
I didn't put the unity/.vscode directory in because I didn't want to mess with the default-generated stuff Unity gave us. I did solidify the python/.vscode directory though
|
|
||
| @private | ||
| def LeaveSession( |
There was a problem hiding this comment.
Why is this function is this Camel Case function named?
There was a problem hiding this comment.
It's a gRPC handler's convention. It has to be camelCase to override the stub handler/interface in ARFlowServiceServicer
| interceptors = [ErrorInterceptor()] # pyright: ignore [reportUnknownVariableType] | ||
| server = grpc.server( # pyright: ignore [reportUnknownMemberType] | ||
| futures.ThreadPoolExecutor(max_workers=10), | ||
| compression=grpc.Compression.Gzip, |
There was a problem hiding this comment.
Any potential real-time performance impact on using compression v.s. no compression?
There was a problem hiding this comment.
Note: this was discussed in a previous meeting. Detailed performance improvement needs to be measured.
There was a problem hiding this comment.
Yes, I took notes of it and will setup benchmark tests after I have done the unit tests for the server code (almost done).
|
Sorry, I just realized I didn't submit the reviews. Take a look at the comments above. |
|
@FelixNgFender The CI is still failing. Can we have a quick fix for that? Maybe ignore some unused pytest code. |
|
I disabled typechecking & testing temporarily for this PR. We will add it back when testing & benchmarking is done. |
No description provided.