Bug fix: Make get_route_info() case insensitive #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mynhardt Burger <Mynhardt.Burger@ibm.com>
…get_route_info will extract the route info Signed-off-by: Mynhardt Burger <Mynhardt.Burger@ibm.com>
…jects as well Signed-off-by: Mynhardt Burger <Mynhardt.Burger@ibm.com>
Signed-off-by: Mynhardt Burger <Mynhardt.Burger@ibm.com>
Signed-off-by: Mynhardt Burger <Mynhardt.Burger@ibm.com>
Signed-off-by: Mynhardt Burger <Mynhardt.Burger@ibm.com>
mynhardtburger
force-pushed
the
case-insensitive-route-info
branch
from
11d854f to
3fe4942
Compare
mynhardtburger
requested review from
gabe-l-hart,
tjohnson31415,
hickeyma,
alex-jw-brooks,
gkumbhat,
evaline-ju and
joerunde
as code owners
gabe-l-hart
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
TGISBackend.get_route_info()'s operation case insensitive.Both gRPC and HTTP defines their metadatum/headers as case insensitive. This requires any lookup of keys to be done in a case insensitive manner.
Additionally fixed the
test_get_route_infotest:TestServicerContextto inherit fromgrpc.ServicesContext. This was required becauseTGISBackend.get_route_info()test if the servicer context is ofgrpc.ServicerContextbefore attempting to access the metadata.latin-1as per http spec and what starlette expects.Note:
Depending on how the
fastapi.Requestobject (actually a starlette.requests.Request object) is created, it might not instantiate its headers in a case insensitive manner. If thestarlette.datastructures.Headersis created via thescope=parameter the header keys still remain case sensitive. This is whyHeaders.get()is not reliable and a customTGISBackend._request_header_get()was necessary.