Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update proto file to the latest in vllm #58

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

waleedqk
Copy link

@waleedqk waleedqk commented Jul 8, 2024

Picking up the latest generation.proto from vllm

Built from:

grpcio                     1.64.1
grpcio-health-checking     1.62.2
grpcio-reflection          1.62.2
grpcio-tools               1.64.1

Signed-off-by: waleedqk <waleedqk@ibm.com>
Copy link
Contributor

@gabe-l-hart gabe-l-hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little NIT about the formatting of generation.proto. If those empty whitespace lines (and also the extra newlines at the end) are coming directly from the vllm version (which I don't think they are looking at it directly), then we can keep them, but if now, I'd like a clean exact copy here.

@@ -4,8 +4,8 @@

syntax = "proto3";
package fmaas;



Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Total NIT, but does this file include these empty whitespace lines in vllm? I really dislike having them, but if this is a straight cp from vllm without any modifications, that's probably better. It may also be good to write a script that does this generation.proto update in place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've confirmed that this does not include any breaking changes

waleedqk added 2 commits July 8, 2024 13:20
Signed-off-by: waleedqk <waleedqk@ibm.com>
Signed-off-by: waleedqk <waleedqk@ibm.com>
Copy link
Contributor

@gabe-l-hart gabe-l-hart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@gabe-l-hart gabe-l-hart merged commit 8265d12 into caikit:main Jul 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants