-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update proto file to the latest in vllm #58
Conversation
Signed-off-by: waleedqk <waleedqk@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One little NIT about the formatting of generation.proto
. If those empty whitespace lines (and also the extra newlines at the end) are coming directly from the vllm
version (which I don't think they are looking at it directly), then we can keep them, but if now, I'd like a clean exact copy here.
caikit_tgis_backend/generation.proto
Outdated
@@ -4,8 +4,8 @@ | |||
|
|||
syntax = "proto3"; | |||
package fmaas; | |||
|
|||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Total NIT, but does this file include these empty whitespace lines in vllm
? I really dislike having them, but if this is a straight cp
from vllm
without any modifications, that's probably better. It may also be good to write a script
that does this generation.proto
update in place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that this does not include any breaking changes
Signed-off-by: waleedqk <waleedqk@ibm.com>
Signed-off-by: waleedqk <waleedqk@ibm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Picking up the latest
generation.proto
from vllmBuilt from: