Bugfix - Don't register connection for local TGIS instances #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mynhardt Burger <Mynhardt.Burger@ibm.com>
mynhardtburger
requested review from
gabe-l-hart,
tjohnson31415,
hickeyma,
alex-jw-brooks,
gkumbhat,
evaline-ju and
joerunde
as code owners
gabe-l-hart
approved these changes
Jun 7, 2024
| @@ -198,6 +200,10 @@ def register_model_connection( | |||
| If `fill_with_defaults == True`, missing keys in `conn_cfg` will be populated | |||
| with defaults from the TGISBackend's config connection. | |||
| """ | |||
| # Don't attempt registering a remote model if running local TGIS instance | |||
| if self.local_tgis: | |||
There was a problem hiding this comment.
Let's throw a debug log in here at least so there's some visibility
Signed-off-by: Mynhardt Burger <Mynhardt.Burger@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#55 added the
TGISBackend.register_model_connection()method.It however has a bug where if called on a TGISBackend() on a locally managed TGIS instance, it will raise an exception:
It will attempt to create a remote model connection with no config (none provided and no default), resulting in attempting to call
.get()onNoneType.This PR is to fix this bug.