Server logging 931 #54
Conversation
swith004
requested review from
gabe-l-hart,
tjohnson31415,
hickeyma,
alex-jw-brooks,
gkumbhat,
evaline-ju and
joerunde
as code owners
caikit_tgis_backend/tgis_backend.py
Outdated
| @@ -101,6 +101,10 @@ def __init__(self, config: Optional[dict] = None): | |||
| # Parse connection objects for all model-specific connections | |||
| for model_id, model_conn_cfg in self._remote_models_cfg.items(): | |||
| model_conn = TGISConnection.from_config(model_id, model_conn_cfg) | |||
|
|
|||
| log.debug( | |||
| "model connection config is set to the following: %s", model_conn_cfg | |||
There was a problem hiding this comment.
Since this corresponds to a model would it be helpful to also log the model_id?
There was a problem hiding this comment.
thanks, @evaline-ju - made the change
There was a problem hiding this comment.
I think what @evaline-ju was referring to was to include model_id in the same log message so its easier to track. So something like:
connection config for model %s : %s
There was a problem hiding this comment.
yes that was what I had intended
There was a problem hiding this comment.
misunderstood - fixing this @evaline-ju @gkumbhat
There was a problem hiding this comment.
I see the DCO check is stuck but could you rebase your commits with the signoff? thanks!
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
swith004
force-pushed
the
server-logging-931
branch
from
2f3e776 to
8d90233
Compare
missed this since update is sent to another email address! Thanks @evaline-ju - forgot the signoff needed in the caikit repos. |
Signed-off-by: Shonda-Adena-Witherspoon <shonda.adena.witherspoon@ibm.com>
This PR adds logging to the model connection configuration in order to debug possible issues in the log.