Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Register test scenarios with ExUnit.Case.register_test/6 #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/cabbage/feature.ex
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,9 @@ defmodule Cabbage.Feature do

name =
ExUnit.Case.register_test(
__ENV__,
__MODULE__,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why don't you use the implementation from ExUnit.Case?

%{module: mod, file: file, line: line} = __ENV__
ExUnitCase.register_test(mod, file, line, :scenario, scenario.name, tags)

__ENV__.file,
__ENV__.line,
:scenario,
scenario.name,
tags
Expand Down