Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove to_string_as method #71

Merged
merged 2 commits into from
Feb 13, 2025
Merged

chore: remove to_string_as method #71

merged 2 commits into from
Feb 13, 2025

Conversation

robjtede
Copy link
Member

@robjtede robjtede commented Feb 11, 2025

the boolean parameter on this for IEC/SI selection is non-obvious

... instead we'll pursue something like #32 or #76

@robjtede robjtede changed the title fix: swap values of LN_KIB & LN_KB chore: remove to_string_as method Feb 11, 2025
Base automatically changed from fix-si-iec to master February 12, 2025 01:28
@robjtede robjtede marked this pull request as ready for review February 12, 2025 01:30
@robjtede robjtede requested a review from MrCroxx February 12, 2025 01:31
@robjtede robjtede mentioned this pull request Feb 12, 2025
@robjtede robjtede requested a review from hyunsik February 12, 2025 12:34
@robjtede robjtede merged commit b8242ef into master Feb 13, 2025
11 checks passed
@robjtede robjtede deleted the rm-to-string-as branch February 13, 2025 13:33
@robjtede robjtede added this to the 2.0 milestone Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant