Skip to content

Commit 4bc8a95

Browse files
authored
fix: stop generating images in advance (#17)
close #12
1 parent 9a56987 commit 4bc8a95

File tree

2 files changed

+4
-7
lines changed

2 files changed

+4
-7
lines changed

src/components/header/export-dialog.tsx

+4-2
Original file line numberDiff line numberDiff line change
@@ -117,9 +117,11 @@ export function ExportImageDialog({
117117
}
118118

119119
if (previewRef.current && previewRef.current.itemRefs.current && previewRef.current.containerRef.current) {
120-
generateImages()
120+
if (isExportModalOpen) {
121+
generateImages()
122+
}
121123
}
122-
}, [previewRef, scale, setIsExporting, isExporting])
124+
}, [previewRef, scale, setIsExporting, isExporting, isExportModalOpen])
123125

124126
const exportImages = useCallback(async () => {
125127
const zip = new JSZip()

src/components/header/header.tsx

-5
Original file line numberDiff line numberDiff line change
@@ -80,11 +80,6 @@ export function Header(props: HeaderProps) {
8080
const { toast } = useToast()
8181
const fileRef = useRef<HTMLInputElement>(null)
8282

83-
useEffect(() => {
84-
// Regenerate images when the contents are updated
85-
setIsExporting(true)
86-
}, [contents])
87-
8883
useEffect(() => {
8984
function handleKeyDown(e: KeyboardEvent) {
9085
if (e.key === 'o' && (e.metaKey || e.ctrlKey)) {

0 commit comments

Comments
 (0)