Added logLoggerAppName parameter in SystemdJournalAppender #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Changed LoggerName string * Changed LoggerName string in test Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
|
Your PR contains import order and formatting changes that I wouldn’t like to merge. Also: Why would you want to change the journal key instead of setting |
|
Hi, thank you for the reply. For the import order and formatting changes, you are right. I can review the commit to remove those changes. Regarding the journal key for the logger it was mainly a request to be able to change it and have something more "tied" to the application instead of having LOG4J_LOGGER reported. Yes, we are using also the syslogIdentifier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have added the possibility to specify, in the log4j file, the name of the Application logging using this appender in order to have that name reported in the journal key for the logger. In this way, if specified by the user, instead of having the key
LOG4J_LOGGERthe journal will be filled withAPPNAME_LOGGERwhereAPPNAMEis specified in the log4j file by thelogLoggerAppNameattribute.