code-review #6
Open
code-review #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated readme 07132017
emmyakin
reviewed
Sep 4, 2017
.travis.yml
Outdated
| - sudo -u postgres createuser bunmialao | ||
| - createdb postit-test | ||
|
|
||
| script: |
There was a problem hiding this comment.
you can omit these two lines
or use 'npm test' instead, there is no need to add "run" for scripts command that are native to npm scripts
Procfile
Outdated
| @@ -0,0 +1 @@ | |||
| web: NODE_ENV=production node server.prod.js | |||
There was a problem hiding this comment.
by default Heroku sets NODE_ENV to production, so, just node server.prod.js is fine
app.js
Outdated
| import routes from './server/routes/index'; | ||
|
|
||
| const port = parseInt(process.env.PORT, 10) || 3000; | ||
| const homepage = `${__dirname}/client/index.html`; |
|
|
||
| routes(app); | ||
|
|
||
| module.exports = app; |
There was a problem hiding this comment.
export default app for consistency with es6 modules
client/Index.jsx
Outdated
| import { createStore, applyMiddleware, compose } from 'redux'; | ||
| import attachAuthorizationToken from "../client/utils/attachToken"; | ||
| import store from '../client/store/configureStore'; | ||
| import { setCurrentUser } from './actions/users'; |
There was a problem hiding this comment.
remember setCurrentUser is a default export, so remove curly braces
| // import { userSignInRequest } from '../../actions/SignInAction'; | ||
| import NavigationBar from '../NavigationBar'; | ||
|
|
||
| class SignInPage extends React.Component { |
client/components/Sidebar.jsx
Outdated
| import ListGroup from './Group/ListGroup'; | ||
|
|
||
|
|
||
| const SideBar=() => ( |
client/components/NavigationBar.jsx
Outdated
| } | ||
|
|
||
| } | ||
| NavigationBar.proptypes = { |
| } | ||
| ); | ||
|
|
||
| const mapDispatchToProps = () => ({ |
There was a problem hiding this comment.
just use an object declaration here rather than using a function
|
|
||
| listUsers (groupId) { | ||
| if (this.props.users.length > 0) return; | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.