Hoist sidekiq into the Gemfile of the starter repo
#1953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we had listed `sidekiq` as a hard dependency of the `core` gems. This (and the joint PR) make it so that we list `sidekiq` directly in the `Gemfile` of the starter repo instead of as a gem dependency of the `core` gems. That will allow people to remove sidekiq if they want to use something else for background processing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had listed
sidekiqas a hard dependency of thecoregems. This (and the joint PR) make it so that we listsidekiqdirectly in theGemfileof the starter repo instead of as a gem dependency of thecoregems. That will allow people to remove sidekiq if they want to use something else for background processing.Joint PR: bullet-train-co/bullet_train-core#1059