Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avo time_zone options #1952

Merged
merged 1 commit into from
Feb 19, 2025
Merged

fix: avo time_zone options #1952

merged 1 commit into from
Feb 19, 2025

Conversation

Paul-Bob
Copy link
Contributor

Fixes #1371

This PR fixes the time_zone select field options on Avo resources.

Previously, the code:

view_context.time_zone_options_for_select(Avo::Current.user.time_zone, nil, ActiveSupport::TimeZone)

was generating a ActiveSupport::SafeBuffer, which is not compatible with the select field options that expects a hash.

@Paul-Bob Paul-Bob mentioned this pull request Feb 19, 2025
Closed
jagthedrummer
jagthedrummer approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@jagthedrummer jagthedrummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jagthedrummer jagthedrummer merged commit 7a438fc into bullet-train-co:main Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagthedrummer jagthedrummer jagthedrummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avo team & user view don't work in production environment
2 participants
@Paul-Bob @jagthedrummer