Add xxhash as an optional gem
#1940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `core` gems used to list `xxhash` as a hard dependency, but it's only used in the generation of random colors for user & team icons. If you have an existing app **and** you need to preserve the random colors that used to be generated you can uncomment this gem and things will continue to work the way they always have. If you don't care about preserving the same random colors then you don't need to include it. Joint PR: bullet-train-co/bullet_train-core#1053
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
coregems used to listxxhashas a hard dependency, but it's only used in the generation of random colors for user & team icons.If you have an existing app and you need to preserve the random colors that used to be generated you can uncomment this gem and things will continue to work the way they always have.
If you don't care about preserving the same random colors then you don't need to include it.
Joint PR: bullet-train-co/bullet_train-core#1053