From c427d45c25a0c94862d6898feb68232fdd7bfbab Mon Sep 17 00:00:00 2001 From: Jeremy Green Date: Wed, 19 Feb 2025 14:04:29 -0600 Subject: [PATCH] Hoist `sidekiq` into the `Gemfile` in the starter repo (#1059) Some people may not want to use Sidekiq. Previously they had to include sidekiq in their production build whether they used it or not. This makes it possible to completely remove Sidekiq by removing it from the `Gemfile` in the starter repo. --- bullet_train-api/Gemfile.lock | 8 -------- bullet_train-fields/Gemfile.lock | 8 -------- bullet_train-incoming_webhooks/Gemfile.lock | 8 -------- bullet_train-integrations-stripe/Gemfile.lock | 8 -------- bullet_train-outgoing_webhooks/Gemfile.lock | 8 -------- bullet_train-sortable/Gemfile.lock | 8 -------- bullet_train-super_scaffolding/Gemfile.lock | 8 -------- bullet_train-themes-light/Gemfile.lock | 8 -------- bullet_train-themes-tailwind_css/Gemfile.lock | 8 -------- bullet_train-themes/Gemfile.lock | 8 -------- bullet_train/Gemfile.lock | 8 -------- bullet_train/bullet_train.gemspec | 3 --- bullet_train/lib/bullet_train.rb | 1 - 13 files changed, 92 deletions(-) diff --git a/bullet_train-api/Gemfile.lock b/bullet_train-api/Gemfile.lock index 4f6f6d645..4e8af8243 100644 --- a/bullet_train-api/Gemfile.lock +++ b/bullet_train-api/Gemfile.lock @@ -77,7 +77,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -371,8 +370,6 @@ GEM rake (13.2.1) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -398,11 +395,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-fields/Gemfile.lock b/bullet_train-fields/Gemfile.lock index 3f477d75f..cc3e31628 100644 --- a/bullet_train-fields/Gemfile.lock +++ b/bullet_train-fields/Gemfile.lock @@ -82,7 +82,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -381,8 +380,6 @@ GEM rb_sys (0.9.105) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -408,11 +405,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-incoming_webhooks/Gemfile.lock b/bullet_train-incoming_webhooks/Gemfile.lock index 91975a664..7359dd7e4 100644 --- a/bullet_train-incoming_webhooks/Gemfile.lock +++ b/bullet_train-incoming_webhooks/Gemfile.lock @@ -91,7 +91,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -376,8 +375,6 @@ GEM rake (13.2.1) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool reline (0.6.0) io-console (~> 0.5) responders (3.1.1) @@ -387,11 +384,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-integrations-stripe/Gemfile.lock b/bullet_train-integrations-stripe/Gemfile.lock index d67bdac3e..2e7b0240f 100644 --- a/bullet_train-integrations-stripe/Gemfile.lock +++ b/bullet_train-integrations-stripe/Gemfile.lock @@ -100,7 +100,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -402,8 +401,6 @@ GEM rake (13.2.1) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool reline (0.6.0) io-console (~> 0.5) responders (3.1.1) @@ -413,11 +410,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-outgoing_webhooks/Gemfile.lock b/bullet_train-outgoing_webhooks/Gemfile.lock index a3349d817..81b9f011e 100644 --- a/bullet_train-outgoing_webhooks/Gemfile.lock +++ b/bullet_train-outgoing_webhooks/Gemfile.lock @@ -91,7 +91,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -379,8 +378,6 @@ GEM rake (13.2.1) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -406,11 +403,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-sortable/Gemfile.lock b/bullet_train-sortable/Gemfile.lock index 0af3c37dd..1eb503443 100644 --- a/bullet_train-sortable/Gemfile.lock +++ b/bullet_train-sortable/Gemfile.lock @@ -91,7 +91,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -377,8 +376,6 @@ GEM rake (13.2.1) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -404,11 +401,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-super_scaffolding/Gemfile.lock b/bullet_train-super_scaffolding/Gemfile.lock index 1acba2a53..3cc3d85b2 100644 --- a/bullet_train-super_scaffolding/Gemfile.lock +++ b/bullet_train-super_scaffolding/Gemfile.lock @@ -82,7 +82,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -371,8 +370,6 @@ GEM rake (13.2.1) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -398,11 +395,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-themes-light/Gemfile.lock b/bullet_train-themes-light/Gemfile.lock index 1262e5929..00f07d08e 100644 --- a/bullet_train-themes-light/Gemfile.lock +++ b/bullet_train-themes-light/Gemfile.lock @@ -98,7 +98,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -386,8 +385,6 @@ GEM rake (13.2.1) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -413,11 +410,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-themes-tailwind_css/Gemfile.lock b/bullet_train-themes-tailwind_css/Gemfile.lock index fbfe41119..cff201aef 100644 --- a/bullet_train-themes-tailwind_css/Gemfile.lock +++ b/bullet_train-themes-tailwind_css/Gemfile.lock @@ -91,7 +91,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -378,8 +377,6 @@ GEM rake (13.2.1) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -405,11 +402,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train-themes/Gemfile.lock b/bullet_train-themes/Gemfile.lock index ee2883993..35609f491 100644 --- a/bullet_train-themes/Gemfile.lock +++ b/bullet_train-themes/Gemfile.lock @@ -83,7 +83,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq PATH remote: . @@ -375,8 +374,6 @@ GEM rb_sys (0.9.105) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -402,11 +399,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train/Gemfile.lock b/bullet_train/Gemfile.lock index 6a2bc4f0a..8f21e1ab6 100644 --- a/bullet_train/Gemfile.lock +++ b/bullet_train/Gemfile.lock @@ -106,7 +106,6 @@ PATH premailer-rails rails (>= 6.0.0) showcase-rails - sidekiq GEM remote: https://rubygems.org/ @@ -404,8 +403,6 @@ GEM rb_sys (0.9.105) rdoc (6.10.0) psych (>= 4.0.0) - redis-client (0.23.0) - connection_pool regexp_parser (2.10.0) reline (0.6.0) io-console (~> 0.5) @@ -431,11 +428,6 @@ GEM securerandom (0.4.1) showcase-rails (0.4.6) rails (>= 6.1.0) - sidekiq (7.3.7) - connection_pool (>= 2.3.0) - logger - rack (>= 2.2.4) - redis-client (>= 0.22.2) simplecov (0.22.0) docile (~> 1.1) simplecov-html (~> 0.11) diff --git a/bullet_train/bullet_train.gemspec b/bullet_train/bullet_train.gemspec index 105715ec0..1a8149537 100644 --- a/bullet_train/bullet_train.gemspec +++ b/bullet_train/bullet_train.gemspec @@ -49,9 +49,6 @@ Gem::Specification.new do |spec| # We use this to add "'s" as appropriate in certain headings. spec.add_dependency "possessive" - # We've standardized on Sidekiq for background job processing. - spec.add_dependency "sidekiq" - # We use this to detect the size of the logo assets. spec.add_dependency "fastimage" diff --git a/bullet_train/lib/bullet_train.rb b/bullet_train/lib/bullet_train.rb index 641e621f1..1ba02d02a 100644 --- a/bullet_train/lib/bullet_train.rb +++ b/bullet_train/lib/bullet_train.rb @@ -20,7 +20,6 @@ # require "rqrcode" require "cancancan" require "possessive" -require "sidekiq" require "fastimage" require "http_accept_language" require "cable_ready"