Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added correct link fixed issue #653 #654

Closed
wants to merge 2 commits into from

Conversation

Srishti-j18
Copy link

I was following the guide, but it was not clear to me that I should start a local registry to actually perform the tasks, will be great if we can make that more clear to the reader.

Signed-off-by: Srishti-j18 <srishti33164jaiswal@gmail.com>
@Srishti-j18 Srishti-j18 requested a review from a team as a code owner February 7, 2024 15:34
Copy link
Member

@AidanDelaney AidanDelaney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Our tests run a local registry, but we never make that clear to the user!

@AidanDelaney
Copy link
Member

I'm hoping that #655 fixes these build issues

@AidanDelaney
Copy link
Member

We made a huge update to our docs. I'll rebase your changes on our latest updates.

@Srishti-j18
Copy link
Author

Hi @AidanDelaney,
I find the documentation on Cloud Native Buildpacks very useful, especially for beginner contributors. I appreciate your efforts in keeping it well-documented. However, there are a few changes that I believe are required. It's great to see that you are actively updating the documentation.
I also wanted to bring your attention to an issue mentioned here: issue 170. I encountered the same problem while going through the documentation. If possible, could you address this issue?
Additionally, let me know if I can contribute to resolving it.

@Srishti-j18
Copy link
Author

Hi @AidanDelaney, I find the documentation on Cloud Native Buildpacks very useful, especially for beginner contributors. I appreciate your efforts in keeping it well-documented. However, there are a few changes that I believe are required. It's great to see that you are actively updating the documentation. I also wanted to bring your attention to an issue mentioned here: issue 170. I encountered the same problem while going through the documentation. If possible, could you address this issue? Additionally, let me know if I can contribute to resolving it.

We can either mention explicitly about this in the documentation manually, or we can address the issue by fixing the sample repository.

@AidanDelaney
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants