Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc search returns broken links #668

Closed
ryanbrainard opened this issue Mar 6, 2024 · 3 comments · Fixed by #671
Closed

Doc search returns broken links #668

ryanbrainard opened this issue Mar 6, 2024 · 3 comments · Fixed by #671

Comments

@ryanbrainard
Copy link

On Page: Getting Started

When using the doc search box in the upper left, there are many results that are returned with dead links. For example, type in mirror and click on one of links (e.g. https://buildpacks.io/docs/tools/pack/cli/pack_config_registry-mirrors_list/) and it is a 404.

2024-03-06_14-18-57
@natalieparellano
Copy link
Member

Content lives at:
https://buildpacks.io/docs/for-platform-operators/how-to/integrate-ci/pack/cli/pack_config_registry-mirrors_list/

Search returns:
https://buildpacks.io/docs/tools/pack/cli/pack_config_registry-mirrors_list/

I think this PR unfortunately aliases each individual pack CLI page to https://buildpacks.io/docs/tools/pack instead of the corresponding https://buildpacks.io/docs/tools/pack/cli/<pack_command_path>

I believe the "correct" solution here is to figure out how to re-generate all our search results!

@ryanbrainard
Copy link
Author

I believe the "correct" solution here is to figure out how to re-generate all our search results!

@natalieparellano Something else to note is that there are also a lot of broken links from Google and other docs, so if we can restore the URLs to their original location (instead of re-generating all our search results), it would probably be better.

natalieparellano added a commit that referenced this issue Mar 7, 2024
Fixes #668

Signed-off-by: Natalie Arellano <narellano@vmware.com>
@natalieparellano
Copy link
Member

@ryanbrainard fair enough. I think #671 will fix this.

@AidanDelaney could you please take a look? 🙏🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants