Make board-embedding configurable, solves #63 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @mikechurchward, @mchurchward, @brickfieldlabs can you approve the workflow? Cheers |
|
Hi @christianwolters , many thanks for this PR, creating a global setting for enabling board embedding! We are very keen to merge this PR now, after doing a code review on it, but would really appreciate it if it could be rebased and AMD regrunted from the latest MOODLE_401_STABLE branch, to make integration easier. Hope you are able to sort this, and apologies for the delay getting to this PR review. Kind regards |
learningtechnologyservices
changed the base branch from
MOODLE_400_STABLE
to
MOODLE_401_STABLE
learningtechnologyservices
force-pushed
the
issue-63
branch
from
8045cc7 to
162c0bc
Compare
learningtechnologyservices
merged commit 356e86b
into
brickfield:MOODLE_401_STABLE
3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @brickfieldlabs,
this PR makes board embedding configurable, globally via admin settings.
Adresses issue #63.
Cheers
Christian