Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Barnard catalog and various UI improvements to Catalog view #153

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

mrosseel
Copy link
Collaborator

@mrosseel mrosseel commented Mar 7, 2024

  • Adding Barnard catalog, except for 2 objects which have an extra letter in their name which we can't handle! e.g. B 44a
  • Allowing more description lines if there is no mag nor size info available (happens regularly in the Barnard catalog)
  • Taking button hints into account when calculating nr of lines shown for the description

With button hints (2 lines of description):
with_buttons

Without button hints (3 lines of description)
without button

Without button hints nor magnitude/size info nor common name line (5 lines of description)
example_no_mag

@mrosseel mrosseel requested a review from brickbots March 7, 2024 16:07
@brickbots brickbots merged commit 1245204 into brickbots:main Mar 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants