Cedar solve #134
Cedar solve #134
Conversation
| from PiFinder.image_util import ( | ||
| gamma_correct_high, | ||
| gamma_correct_med, | ||
| gamma_correct_low, | ||
| subtract_background, | ||
| ) | ||
| from PiFinder.ui.base import UIModule | ||
| import numpy as np |
There was a problem hiding this comment.
No need to change this now, but it reminded me to tell you that I'm planning to implement isort linting of imports at some point. I'll do a full pass on the code base and set up a pre-commit to just run and modify the files:
https://pypi.org/project/isort/
I'll probably do this along with getting mypy up and running with very loose checking initially and then tightening it down as we update the code.
python/PiFinder/solver.py
Outdated
|
|
||
|
|
||
| def solver(shared_state, solver_queue, camera_image, console_queue, is_debug=False): | ||
| import cedar_detect_client |
There was a problem hiding this comment.
I'm curious why you choose to put these imports here rather than at the top of the file? Is there some advantage or style desire?
| centroids, | ||
| (512, 512), | ||
| fov_estimate=10.2, | ||
| match_max_error=0.005, |
There was a problem hiding this comment.
I'd like to leave the fov_max_error parameter in here, but it can go to 1.0 rather than 0.5.
| cent_image_obj, | ||
| sigma_mode="local_median_abs", | ||
| filtsize=11, | ||
| if self.align_mode and self.shared_state and self.shared_state.solution(): |
There was a problem hiding this comment.
I'll have to dig into this a bit more.... but it seems like this would only allow alignment if the solver is working (which may not be that bad an idea). Also, would a planet show up in the matched_centroids key? The current code just matches anything bright for alignment, even if it's not a match to the star-patterns
requirements.txt
Outdated
| @@ -4,7 +4,7 @@ bottle==0.12.25 | |||
| cheroot==10.0.0 | |||
| gpsdclient==1.3.2 | |||
| luma.oled==3.12.0 | |||
| pillow==9.5.0 | |||
| pillow | |||
There was a problem hiding this comment.
Was 9.5.0 not working in some way? If not, what version did pip end up pulling for you so we can add it here (pip list)? I like to keep the requirements file version locked just to avoid any mysterious issues from one image build to the next.
requirements.txt
Outdated
| @@ -17,4 +17,5 @@ sh==1.14.3 | |||
| skyfield==1.45 | |||
| timezonefinder==6.1.9 | |||
| tqdm==4.65.0 | |||
| alpyca | |||
| grpcio | |||
There was a problem hiding this comment.
Let's also specify the versions here 👍
No description provided.