LPD-29348 Change the reference from the attachment to the Object entry from ID to ERC #153938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# breaking ## What modules/apps/object/object-api/src/main/java/com/liferay/object/field/attachment/AttachmentManager.java The methods named 'addFileEntry' were replaced with methods named 'getOrAddFileEntry'. ## Why To introduce a new feature: get the file entry by the ERC, if it exists, or add it, if it does not. ----
…InDocumentsAndMedia' is false
… to create the empty shell and the fileBase64 will be in the body in some cases
…nDocumentsAndMedia' is false
…n the appropriate group
…count when creating the empty shell
|
To conserve resources, the PR Tester does not automatically run for every pull. If your code changes were already tested in another pull, reference that pull in this pull so the test results can be analyzed. If your pull was never tested, comment "ci:test" to run the PR Tester for this pull. |
|
@devpedrotavares much better. We're close. But in that test, I see serviceBuilderFileEntry vs. testFileEntry vs. createdFileEntry I"m not able to wrap my head around seeing consistent usage of this. Can you rename them for consistency? Thx. Please resend on top of devpedrotavares#83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up: #153919