Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fastani: Bump revision for gcc@9 #1309

Closed
wants to merge 1 commit into from
Closed

fastani: Bump revision for gcc@9 #1309

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Formula/fastani.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ class Fastani < Formula
url "https://github.com/ParBLiSS/FastANI/archive/v1.32.tar.gz"
sha256 "f66b3bb5b272aa3db4deae782e47020fa9aae63eecbbd6fd93df876237d3b2e5"
license "Apache-2.0"
revision 1
head "https://github.com/ParBLiSS/FastANI.git"

bottle do
Expand All @@ -20,6 +21,7 @@ class Fastani < Formula
uses_from_macos "zlib"

on_macos do
depends_on "gcc@9"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
depends_on "gcc@9"

fastani uses libomp for OpenMP support in Clang, rather than using GCC, so it does not depend on GCC.
See PR https://github.com/brewsci/homebrew-bio/pull/1088/files
Because of that, this PR is no longer needed.

depends_on "libomp"
end

Expand All @@ -33,15 +35,16 @@ def install
"--prefix=#{prefix}",
"--with-gsl=#{Formula["gsl"].opt_prefix}",
"--with-boost=#{Formula["boost"].opt_prefix}"
system "gzip", "-9f", *Dir["data/*.fna"]
system "make", "install"
pkgshare.install "data", "scripts"
end

test do
assert_match "fragment length", shell_output("#{bin}/fastANI --help 2>&1")
system "#{bin}/fastANI",
"-q", pkgshare/"data/Shigella_flexneri_2a_01.fna",
"-r", pkgshare/"data/Escherichia_coli_str_K12_MG1655.fna",
"-q", pkgshare/"data/Shigella_flexneri_2a_01.fna.gz",
"-r", pkgshare/"data/Escherichia_coli_str_K12_MG1655.fna.gz",
"-o", testpath/"out",
"--matrix"
assert_predicate testpath/"out", :exist?
Expand Down