-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downcase domain in lightning address and return normalized address #695
Conversation
41072fd
to
b4e960c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small suggestion in a comment, otherwise LGTM.
Thanks for the contribution!
libs/sdk-core/src/input_parser.rs
Outdated
/// | ||
/// The result is a tuple of (domain, LNURL-pay endpoint) | ||
fn ln_address_decode(ln_address: &str) -> Result<(String, String)> { | ||
/// The result is a tuple of (domain, LNURL-pay endpoint, lightning address) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/// The result is a tuple of (domain, LNURL-pay endpoint, lightning address) | |
/// The result is a tuple of (domain, LNURL-pay endpoint, lowercase lightning address) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to:
/// The result is a tuple of (domain, LNURL-pay endpoint, downcased lightning address)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b4e960c
to
a5893f6
Compare
utACK a5893f6 |
The PR suggests to return and store normalized lightning address (downcased username and domain), such that it is stored and returned to the SDK user. Rationale here is to present what was the actual address satoshis were sent to.
Close #666.