Create encodable for credit cards post

[warmkesselj]

Summary of changes

Move /credit_cards POST to Encodable.

Checklist

• Added a changelog entry
• Tested and confirmed payment flows affected by this change are functioning as expected

Authors

@warmkesselj
@jwarmkessel

[richherrera]

Why do we evaluate whether the firstName is not null to create the BillingAddress? I believe that BillingAddress is optional and does not depend on the firstName. What do you think?

Suggested change

	if card.firstName != nil {
	self.billingAddress = BillingAddress(card: card)
	}
	self.billingAddress = BillingAddress(card: card)

[warmkesselj]

This was the original logic. If we don't need it that would be fantastic. @jaxdesmarais can you weigh in on whether this is a business rule?

[jaxdesmarais]

I don't see where the logic to check the first name existed for billing address unless I am missing it: https://github.com/braintree/braintree_ios/blob/main/Sources/BraintreeCard/BTCard.swift. Looks like that was changed in this PR.

[warmkesselj]

I think you're right. I'm not sure why I remembered some logic that encased the BillingInfo...

[warmkesselj]

Okay, I think we can remove this condition here in func encode

                 if let billingAddress {
                        try container.encodeIfPresent(billingAddress, forKey: .billingAddress)
                    }

But we still need to keep a conditional check here

init(card: BTCard) {
    if [someCondition]                 
     self.billingAddress = BillingAddress(card: card)

Doing so will keep this original logic intact for not sending an empty BillingAddress json object

          if !billingAddressDictionary.isEmpty {
            cardDictionary["billingAddress"] = billingAddressDictionary
        }

[jaxdesmarais]

Gotcha, that makes sense to me. Thanks for tracking that down. Maybe here we can do if !card.billingAddress. isEmpty to match the rest of the object? What do you think?

[warmkesselj]

Hmm.. I don't see a property for billingAddress.

[jaxdesmarais]

Ah you may be right, I don't think it exists yet. Maybe then doing this makes the most sense:

if let billingAddress {
    try container.encodeIfPresent(billingAddress, forKey: .billingAddress)
}

I think there are cases when merchants pass a billing address but don't pass a first name, and with the logic as is we just wouldn't pass the other details along even if they existed if no firstName exists.