-
-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL 2.0.6 and 2.0.7 #410
Comments
Thanks David. I'll investigate further. I'm having problems getting SFX working at all using the newly released SDL 2.0.6, which is why I haven't committed it yet. (See https://discourse.libsdl.org/t/sdl-2-0-6-released/23109/3?u=bradharding) |
Filed a bug with SDL: |
For visibility - this seems related: pjasicek/OpenClaw#122 |
This has been resolved upstream by SDL devs. https://bugzilla.libsdl.org/show_bug.cgi?id=3858 |
@fragglet thanks for your efforts. |
Thanks Fraggle. I think I might wait for the next official release of SDL (2.0.7?) and SDL_mixer (2.0.2?) (which I'm guessing won't be too far away) for DR's next build. |
@devnexen, does your solution of tripling the size of the allocated memory for the sound still fix this issue for 2.0.7? |
well I was finally able to test doomretro under FreeBSD and Mac with SDL 2.0.7 both works well so false alarm (fortunately :-) ) but for chocolate-doom the problem is real. |
In fact not too surprising after a deeper look, that comes (in my opinion) from this change you did a little while ago 70ba911#diff-c38e1305b41fcfdb9d2b7a3ca18569f9 |
I use Arch Linux and it is the version 2.0.6 shipped with
I do not have profound knowledge of SDL audio but it seems that this version needs a bigger buffer otherwise the game crashes when the first sound tries to be played (tested only Doom II), this I was wondering if changing slighty https://github.com/bradharding/doomretro/blob/master/src/i_sound.c#L162
would fit ? In my case if I allocated from 3 times the memory needed it worked like 2.0.5 did but maybe @bradharding would have a better solution. Cheers.
The text was updated successfully, but these errors were encountered: