Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Result variables: Minor improvements #33

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Conversation

philippfromme
Copy link
Contributor

@philippfromme philippfromme commented Jan 2, 2025

Proposed Changes

Looking into #30 I found it hard to understand the logic. This PR aims to

  • improve the documentation
  • simplify the check for existing outputs
  • improve code style

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clean-up, thanks!

@nikku nikku requested a review from abdul99ahad January 2, 2025 15:21
@philippfromme philippfromme merged commit 930eb59 into main Jan 2, 2025
4 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jan 2, 2025
@philippfromme philippfromme deleted the result-variables branch January 2, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants