feat(popup-menu): add fuzzy search #908
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
reviewed
May 28, 2024
| @@ -453,76 +455,6 @@ describe('features/popup-menu - <PopupMenu>', function() { | |||
| }); | |||
|
|
|||
|
|
|||
| it('should search description', async function() { | |||
There was a problem hiding this comment.
I see how this is properly covered in PopupMenuSpec. ✔️
nikku
reviewed
May 28, 2024
There was a problem hiding this comment.
Two thoughts:
- We introduce another library, let's assess the weight it adds (to a standard modeling distribution)
- We introduce fuzzy search, do we want to provide it as a feature so other parts can build on top? We have a
searchfeature and I'd argue it should use the same behavior.
Alternative:
- Make search a pluggable concern, and plug-in fuzzy search outside of the core.
philippfromme
force-pushed
the
fuzzy-search
branch
from
191f5fa to
0b4d464
Compare
If we were to do this, at would level would we include fuzzy search? camunda-bpmn-js? |
|
@philippfromme Depends; for our use-case it would probably be camunda-bpmn-js, yes. |
|
Since the solution is going to be fairly different, I will close this PR and open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to camunda/camunda-modeler#4122
Test via
npx @bpmn-io/sr bpmn-io/bpmn-js#fuzzy-search -l bpmn-io/diagram-js#fuzzy-search