Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(resolver): simplify local require #161

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Conversation

nikku
Copy link
Member

@nikku nikku commented Feb 15, 2025

Proposed Changes

Module#createRequire is supported since Node@12.x, and can hence safely be used (given our target of Node 18+).

Depends on #164 for 🟢 CI.

Checklist

To ensure you provided everything we need to look at your PR:

  • Brief textual description of the changes present
  • Visual demo attached
  • Steps to try out present, i.e. using the @bpmn-io/sr tool
  • Related issue linked via Closes {LINK_TO_ISSUE} or Related to {LINK_TO_ISSUE}

@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Feb 15, 2025
@nikku nikku mentioned this pull request Feb 15, 2025
4 tasks
@nikku nikku requested review from a team, philippfromme and barmac and removed request for a team February 16, 2025 19:27
@nikku nikku force-pushed the simplify-create-require branch from 80a5a01 to b390c6f Compare February 17, 2025 08:19
Module#createRequire is supported since Node@12.x.
@nikku nikku force-pushed the simplify-create-require branch from b390c6f to 482d572 Compare February 17, 2025 10:07
@nikku nikku merged commit 0ff4342 into main Feb 17, 2025
7 of 9 checks passed
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Feb 17, 2025
@nikku nikku deleted the simplify-create-require branch February 17, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant