Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add account id to STS and SSO providers #3381

Conversation

alexgromero
Copy link
Contributor

This PR adds support to source an account ID from AssumeRoleProvider, AssumeRoleWithWebIdentityProvider, and SSOProvider. The account ID will be resolved after receiving a successful response from a given provider and then be associated with the credentials object.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (account-id-endpoint-routing@8764f68). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                      Coverage Diff                       @@
##             account-id-endpoint-routing    #3381   +/-   ##
==============================================================
  Coverage                               ?   93.10%           
==============================================================
  Files                                  ?       66           
  Lines                                  ?    14568           
  Branches                               ?        0           
==============================================================
  Hits                                   ?    13564           
  Misses                                 ?     1004           
  Partials                               ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexgromero alexgromero requested a review from SamRemis February 12, 2025 21:34
@alexgromero alexgromero force-pushed the account-id-endpoint-routing branch from 1882453 to 17f262a Compare February 12, 2025 21:59
@alexgromero alexgromero force-pushed the add-credentials-sts-sso-providers branch from dfcb30c to cdf2138 Compare February 13, 2025 15:13
@alexgromero alexgromero requested a review from SamRemis February 13, 2025 15:15
@alexgromero alexgromero force-pushed the add-credentials-sts-sso-providers branch from cdf2138 to 453e16b Compare February 19, 2025 19:38
@alexgromero alexgromero merged commit 3f4790e into boto:account-id-endpoint-routing Feb 20, 2025
38 checks passed
@alexgromero alexgromero deleted the add-credentials-sts-sso-providers branch February 20, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants