Remove payload length cap from Event Stream messages #3371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Windows builds seem to be struggling with the larger payload. I'll investigate what's currently failing, it's not clear in the logs. |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3371 +/- ##
==========================================
Coverage ? 93.05%
==========================================
Files ? 66
Lines ? 14478
Branches ? 0
==========================================
Hits ? 13472
Misses ? 1006
Partials ? 0 ☔ View full report in Codecov by Sentry. |
nateprewitt
force-pushed
the
eventstream_limit
branch
from
26a9b47 to
0fdd458
Compare
nateprewitt
force-pushed
the
eventstream_limit
branch
from
0fdd458 to
e079501
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In initial implementations of Event Streams, there was a 16MB payload limit for Event Stream payloads. Anything exceeding that was considered malformed. In more modern implementations, that limit has been raised with some services using 24MB. We'll be removing this client-side check going forward as it doesn't serve a practical purpose. The checksum will be used to validate the payload and size limitations will be left to the service to determine going forward.