Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add length #13

Merged
merged 10 commits into from
Nov 13, 2024
Merged

Add length #13

merged 10 commits into from
Nov 13, 2024

Conversation

boswelja
Copy link
Owner

@boswelja boswelja commented Sep 23, 2024

New API for Length conversions
Part of #5

@boswelja boswelja self-assigned this Sep 23, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 23, 2024
@boswelja boswelja marked this pull request as ready for review November 13, 2024 08:45
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

detekt found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

internal val fromMeter: (BigDecimal) -> BigDecimal,
) {
// SI Metric
METER({ it }, { it }),

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property METER is missing documentation.
) {
// SI Metric
METER({ it }, { it }),
KILOMETER(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property KILOMETER is missing documentation.
it / 1000
}
),
CENTIMETER(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property CENTIMETER is missing documentation.
it * 100
}
),
MILLIMETER(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property MILLIMETER is missing documentation.
}
),
// US Customary
THOU(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property THOU is missing documentation.
},
fromMeter = { it * 3.28084.toBigDecimal() }
),
YARD(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property YARD is missing documentation.
},
fromMeter = { it * 1.09361.toBigDecimal() }
),
MILE(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property MILE is missing documentation.
},
fromMeter = { it * 0.000621371.toBigDecimal() }
),
LEAGUE(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property LEAGUE is missing documentation.
fromMeter = { it * 0.000207123.toBigDecimal() }
),
// Marine
NAUTICAL_MILE(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property NAUTICAL_MILE is missing documentation.
},
fromMeter = { it * 0.000539957.toBigDecimal() }
),
FATHOM(

Check warning

Code scanning / detekt

Public properties require documentation. Warning

The property FATHOM is missing documentation.
@boswelja boswelja merged commit 9edf5f1 into main Nov 13, 2024
11 of 12 checks passed
@boswelja boswelja deleted the distance branch November 13, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant