split unit tests into seperate files

.pre-commit-config.yaml

@@ -18,7 +18,7 @@ repos:
     rev: 'v1.11.2'
     hooks:
       - id: "mypy"
-        exclude: "src/.*/tests.py|src/.*/migrations/.*.py|src/.*/tests/.*"
+        exclude: "src/.*/migrations/.*.py"
         additional_dependencies:
           - "django-stubs[compatible-mypy]"
           - "django-stubs-ext"

pyproject.toml

@@ -122,7 +122,7 @@ convention = "google"
 ########## PYTEST ##########
 [tool.pytest.ini_options]
 DJANGO_SETTINGS_MODULE = "bma.settings"
-python_files = ["tests.py", "test_*.py"]
+python_files = ["tests/test_*.py"]
 log_cli = 1
 log_cli_level = "DEBUG"
 filterwarnings = [
@@ -169,6 +169,7 @@ commands = [["pytest"]]
 [tool.coverage.run]
 omit = [
     "*/tests.py",
+    "*/tests/test_*.py",
 ]
 [tool.coverage.report]
 exclude_also = [

src/albums/tests/__init__.py

@@ -0,0 +1 @@
+"""Unit tests for the albums app."""

src/files/tests/__init__.py

@@ -0,0 +1 @@
+"""Unit tests for the files app."""

src/files/tests/test_admin.py

@@ -0,0 +1,153 @@
+"""Tests for the file HTML views."""
+
+from django.urls import reverse
+
+from utils.tests import BmaTestBase
+
+
+class TestFileAdmin(BmaTestBase):
+    """Tests for the FileAdmin."""
+
+    def test_file_list_status_code(self) -> None:
+        """Test the access controls for the list page in the FileAdmin."""
+        url = reverse("file_admin:files_basefile_changelist")
+        # try accessing the file_admin without a login
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 302)
+        # try accessing the file_admin with a user without permissions for it
+        self.client.login(username="user0", password="secret")
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 302)
+        # try accessing the file_admin with a user with is_creator=True
+        self.client.login(username="creator2", password="secret")
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 200)
+        # try accessing the file_admin with a user with is_moderator=True
+        self.client.login(username="moderator4", password="secret")
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 200)
+        # try accessing the file_admin with a user with is_curator=True
+        self.client.login(username="curator6", password="secret")
+        response = self.client.get(url)
+        self.assertEqual(response.status_code, 302)
+
+    def test_file_list(self) -> None:
+        """Test the file list page in the FileAdmin."""
+        # upload some files
+        self.files = [self.file_upload() for _ in range(10)]
+        for _ in range(10):
+            self.files.append(self.file_upload(uploader="creator3"))
+
+        # the superuser can see all files
+        url = reverse("file_admin:files_basefile_changelist")
+        self.client.login(username="superuser", password="secret")
+        response = self.client.get(url)
+        self.assertInHTML(
+            '<p class="paginator">20 files</p>', response.content.decode(), msg_prefix="superuser can not see 20 files"
+        )
+
+        # each creator can see 10 files
+        for c in ["creator2", "creator3"]:
+            self.client.login(username=c, password="secret")
+            response = self.client.get(url)
+            self.assertInHTML(
+                '<p class="paginator">10 files</p>',
+                response.content.decode(),
+                msg_prefix=f"creator {c} can not see 10 files",
+            )
+
+        # each moderator can see all 20 files
+        for m in ["moderator4", "moderator5"]:
+            self.client.login(username=m, password="secret")
+            response = self.client.get(url)
+            self.assertInHTML(
+                '<p class="paginator">20 files</p>',
+                response.content.decode(),
+                msg_prefix=f"moderator {m} can not see 20 files",
+            )
+
+        # make moderator4 approve 5 of the files owned by creator2
+        data = {"action": "approve", "_selected_action": self.files[:5]}
+        self.client.login(username="moderator4", password="secret")
+        response = self.client.post(url, data, follow=True)
+        self.assertEqual(response.status_code, 200)
+        self.assertInHTML(
+            '<p class="paginator">20 files</p>',
+            response.content.decode(),
+            msg_prefix=f"moderator {m} can not see 20 files",
+        )
+
+        # test filtering to see only approved files
+        response = self.client.get(url + "?approved__exact=1")
+        self.assertInHTML(
+            '<p class="paginator">5 files</p>', response.content.decode(), msg_prefix="can not see 5 approved files"
+        )
+
+        # each creator can still see 10 files
+        for c in ["creator2", "creator3"]:
+            self.client.login(username=c, password="secret")
+            response = self.client.get(url)
+            self.assertInHTML(
+                '<p class="paginator">10 files</p>',
+                response.content.decode(),
+                msg_prefix=f"creator {c} can not see 10 files",
+            )
+
+        # make creator2 publish the 5 approved files
+        data = {"action": "publish", "_selected_action": self.files[:5]}
+        self.client.login(username="creator2", password="secret")
+        response = self.client.post(url, data, follow=True)
+        self.assertEqual(response.status_code, 200)
+        self.assertInHTML(
+            '<p class="paginator">10 files</p>', response.content.decode(), msg_prefix="creator2 can not see 10 files"
+        )
+        response = self.client.get(url + "?published__exact=1")
+        self.assertInHTML(
+            '<p class="paginator">5 files</p>', response.content.decode(), msg_prefix="can not see 5 published files"
+        )
+
+        # make creator2 unpublish the 5 approved files
+        data = {"action": "unpublish", "_selected_action": self.files[:5]}
+        response = self.client.post(url, data, follow=True)
+        self.assertEqual(response.status_code, 200)
+        self.assertInHTML(
+            "5 files selected to be unpublished, "
+            "out of those 5 files had needed permission, "
+            "and out of those 5 files were successfully unpublished",
+            response.content.decode(),
+            msg_prefix="unpublished message not found",
+        )
+        self.assertInHTML(
+            '<p class="paginator">10 files</p>', response.content.decode(), msg_prefix="creator2 can not see 10 files"
+        )
+        response = self.client.get(url + "?published__exact=0")
+        self.assertInHTML(
+            '<p class="paginator">10 files</p>',
+            response.content.decode(),
+            msg_prefix="creator2 can not see 10 unpublished files after unpublishing",
+        )
+
+        # make moderator4 unapprove 5 of the files owned by creator2
+        data = {"action": "unapprove", "_selected_action": self.files[:5]}
+        self.client.login(username="moderator4", password="secret")
+        response = self.client.post(url, data, follow=True)
+        self.assertEqual(response.status_code, 200)
+        response = self.client.get(url + "?approved__exact=0")
+        self.assertInHTML(
+            '<p class="paginator">20 files</p>',
+            response.content.decode(),
+            msg_prefix=f"moderator {m} can not see 20 files pending moderation",
+        )
+
+        # make creator2 softdelete the 5 approved and pubhlished files
+        data = {"action": "softdelete", "_selected_action": self.files[:5]}
+        self.client.login(username="creator2", password="secret")
+        response = self.client.post(url, data, follow=True)
+        self.assertEqual(response.status_code, 200)
+        self.assertInHTML(
+            '<p class="paginator">10 files</p>', response.content.decode(), msg_prefix="creator2 can not see 10 files"
+        )
+        response = self.client.get(url + "?deleted__exact=1")
+        self.assertInHTML(
+            '<p class="paginator">5 files</p>', response.content.decode(), msg_prefix="can not see 5 deleted files"
+        )