Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix homebrew include path. #472

Merged
merged 2 commits into from
Feb 2, 2025
Merged

Fix homebrew include path. #472

merged 2 commits into from
Feb 2, 2025

Conversation

stefanseefeld
Copy link
Member

No description provided.

@pdimov
Copy link
Member

pdimov commented Feb 1, 2025

This seems to have worked, but the build now fails for a different reason, Optional requires C++11. I see that the command line passes cxxflags=-std=c++11, but then the log says

configuration check results:
  has_cxx11 : False 
  has_numpy : False 

so it looks like this doesn't take for some reason.

Maybe faber should be modified to print the command line on failure, like b2 does.

The problem could be that the makedep rule doesn't apply cxxflags.

@stefanseefeld stefanseefeld merged commit 4fe3403 into develop Feb 2, 2025
39 checks passed
@stefanseefeld
Copy link
Member Author

stefanseefeld commented Feb 2, 2025

Good catch @pdimov . Indeed, faber uses the cppflags feature to configure the pre-processor, and cxxflags for the (C++) compiler. Setting the -std option in both has fixed the build problem. Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants