Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextView에서 CustomView Drag-Drop시 Preview가 제대로 나오지 않던 문제 수정 #156

Merged
merged 2 commits into from
Dec 10, 2024
Merged

TextView에서 CustomView Drag-Drop시 Preview가 제대로 나오지 않던 문제 수정 #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12ab2f0
refactor: 프리뷰가 제대로 뜨도록 수정
iceHood Dec 10, 2024
281285b
refactor: 필요없는 코드 제거
iceHood Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions MemorialHouse/MHPresentation/MHPresentation/Source/EditBook/View/EditPageCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ final class EditPageCell: UITableViewCell {
super.prepareForReuse()

input.send(.pageWillDisappear)
cancellables.forEach { $0.cancel() }
cancellables = []
viewModel = nil
textView.text = ""
Expand Down Expand Up @@ -158,6 +157,7 @@ final class EditPageCell: UITableViewCell {
let attachmentString = NSAttributedString(attachment: mediaAttachment)
// Placeholder(공백) 교체
mutableAttributedString.replaceCharacters(in: range, with: attachmentString)
mediaAttachment.dataSource = self
}

mutableAttributedString.addAttributes(
Expand Down Expand Up @@ -264,9 +264,8 @@ final class EditPageCell: UITableViewCell {
shouldChangeTextIn: NSRange(location: textStorage.length, length: 0),
replacementText: text
) else { return }
textStorage.beginEditing()
attachment.dataSource = self
textStorage.append(text)
textStorage.endEditing()
}
}

Expand Down
1 change: 0 additions & 1 deletion ...rialHouse/MHPresentation/MHPresentation/Source/EditBook/ViewModel/EditPageViewModel.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ final class EditPageViewModel: ViewModelType {
}

private func pageWillDisappear() {
cancellables.forEach { $0.cancel() }
cancellables = []
}

Expand Down
Loading