feat: add app uninstall functionality #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver006
approved these changes
Feb 26, 2024
|
Thanks for adding that, that's great! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #267 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 51 52 +1
Lines 2207 2211 +4
=========================================
+ Hits 2207 2211 +4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to uninstall an app over the Shopify REST API by calling DELETE on the admin/api_permissions resource. Documentation for this functionality is found on Shopify API docs here. Note that DELETE is the only method allowed on the api_permissions resource, hence it is the only method implemented.
I’ve added a test and tested manually to confirm this works, but please let me know if I’ve missed anything!