Fix/enable decoupled tan submission #145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my second attempt to fix #131 after #142 was merged but had a problem related to outdated dependencies.
It includes the same commits and an additional commit updating the nemiah/phpfints dependency.
I used the following command
composer update nemiah/php-fints phpspec/prophecy phpunit/phpunit
. prophecy and phpunit had to be updated as well (I guess it is related to the requirement of php>=8.0).Using a locally built docker container I could also import statements successfully, so I think the current dependency situation should not lead to any more problems.
This also brings up the question if anything else has to be done due to the new requirement php>=8.0?
To keep everything together, here also the important part of the description of the old PR:
This adds the basic functionality for decoupled TAN checks, presented by phpFinTs.
I could confirm this working with my Sparkasse bank account.
However, this implementation has a caveat: Confirming the import in the pushTAN app is necessary every time an import is started. Also this adds an entry to the list of saved devices in device management (Geräteverwaltung).
This is also an issue in phpFinTs: nemiah/phpFinTS#453, where it is described as an issue with the "kundensystemId"