Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/enable decoupled tan submission #145

Merged

Conversation

JuliusFreudenberger
Copy link
Contributor

This is my second attempt to fix #131 after #142 was merged but had a problem related to outdated dependencies.
It includes the same commits and an additional commit updating the nemiah/phpfints dependency.
I used the following command composer update nemiah/php-fints phpspec/prophecy phpunit/phpunit. prophecy and phpunit had to be updated as well (I guess it is related to the requirement of php>=8.0).
Using a locally built docker container I could also import statements successfully, so I think the current dependency situation should not lead to any more problems.

This also brings up the question if anything else has to be done due to the new requirement php>=8.0?

To keep everything together, here also the important part of the description of the old PR:
This adds the basic functionality for decoupled TAN checks, presented by phpFinTs.
I could confirm this working with my Sparkasse bank account.

However, this implementation has a caveat: Confirming the import in the pushTAN app is necessary every time an import is started. Also this adds an entry to the list of saved devices in device management (Geräteverwaltung).
This is also an issue in phpFinTs: nemiah/phpFinTS#453, where it is described as an issue with the "kundensystemId"

This now includes a requirement of php>=8.0 and thus updates to phpunit

Refs bnw#131
This is required for example for TAN mode 923 called pushTAN 2.0 by Sparkasse.
This mode requires a confirmation in the pushTAN app but no TAN to be entered.
The implementation presents the same tan-challenge screen without the text input. Instead of submitting a TAN, the decoupled submission is checked through the fints-library.

Refs bnw#131
This enables the selection of the new pushTAN 2.0 authentication by Sparkasse.

Refs bnw#131
@bnw
Copy link
Owner

bnw commented Sep 16, 2024

Again, thanks a lot! 😊
The current dockerfile already uses php 8.1, so this should not be a problem.
It’s normal that updating one package also requires updating some others. But these ones are probably not problematic 👍

@bnw bnw merged commit 822b8f4 into bnw:master Sep 16, 2024
@bnw bnw mentioned this pull request Sep 16, 2024
@JuliusFreudenberger JuliusFreudenberger deleted the fix/enable-decoupled-tan-submission branch September 18, 2024 12:05
@JuliusFreudenberger
Copy link
Contributor Author

I did another test in the docker environment using the image provided by you and I did not encounter any errors.
Now I can import my statements into firefly again.

@UebertreibeR
Copy link

UebertreibeR commented Sep 22, 2024

Hi @JuliusFreudenberger ,
thanks for your work on this - I can confirm the pushTAN 2.0 is now working with the latest release.

Were you able to work around the issue of having to manually confirm pushTAN on every import? There has to be a solution as it works fine for 90 days on other (paid) platforms once a device is added as "trustworthy"

@JuliusFreudenberger
Copy link
Contributor Author

As you opened #149, I will answer there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sparkasse import stopped working
3 participants