feat(vdn): add bootnode implementation #2941
Conversation
| } | ||
| server.Start() | ||
| defer server.Stop() | ||
| select {} |
There was a problem hiding this comment.
It's may better to add a graceful shutdown logic here~
There was a problem hiding this comment.
there is defer on line above, I think it should be sufficient
| QueueSize int | ||
| EnableQuic bool | ||
| EnableDiscovery bool | ||
| MinimumSyncPeers int |
There was a problem hiding this comment.
Why remove this field MinimumSyncPeers?
There was a problem hiding this comment.
I don't think we need it, if there is at least 1 peer you should broadcast right ?
| routingDiscovery := drouting.NewRoutingDiscovery(s.dht) | ||
| // Advertise ourselves under the Rendezvous string | ||
| log.Info("Advertising Rendezvous", "topic", Rendezvous) | ||
| dutil.Advertise(s.ctx, routingDiscovery, Rendezvous) |
There was a problem hiding this comment.
I think your implementation of Rendezvous is not centralized. Right? It does not relay on a central point, because of every node will Advertise?
There was a problem hiding this comment.
Does Rendezvous guarantee that all nodes will be discovered eventually?
There was a problem hiding this comment.
yes, but you need to kind of have a bootstrap address basically, I wanted to make in a way that any node could become bootstrap in case something goes wrong.
Description
This PR is adding new Rendezvous VDN bootnode standalone binary. With this we will be able to bootstrap new network easily.
Example