Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React Query (Tanstack) for API call's and state management in client components #232

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

parwatcodes
Copy link
Member

Description

  • This PR adds "@tanstack/react-query": "^5.66.0", "@tanstack/react-query-devtools": "^5.66.0",
  • Created Query Provider in /providers directory
  • Updated the documents component to use tanstack query for data fetching and mutating.

@parwatcodes parwatcodes self-assigned this Feb 24, 2025
Copy link
Collaborator

@mahid797 mahid797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

  • Please refactor the hooks.
  • Make sure to pull the latest changes from dev before committing to avoid any merge conflicts.


return (
<QueryClientProvider client={queryClient}>
<div style={{ fontSize: '1rem' }}>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <div> wrapping ReactQueryDevtools seems unnecessary and doesn’t relate to its functionality.

@mahid797 mahid797 added New Feature New feature to be implemented Frontend Frontend Related Issue labels Feb 26, 2025
@mahid797 mahid797 added this to the v0.1 milestone Feb 26, 2025
@mahid797 mahid797 self-requested a review February 27, 2025 01:05
Copy link
Collaborator

@mahid797 mahid797 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍🏻

Please resolve the merge conflict so I can merge it.

@mahid797 mahid797 added the ⚡Important High-impact issue that needs to be resolved before the next release label Feb 27, 2025
@parwatcodes parwatcodes requested a review from mahid797 March 2, 2025 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frontend Frontend Related Issue ⚡Important High-impact issue that needs to be resolved before the next release New Feature New feature to be implemented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants