Move function for getting frame duration from dls-bluesky-core (from i22-bluesky) to ScanSpec #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #93 +/- ##
==========================================
+ Coverage 96.05% 96.09% +0.03%
==========================================
Files 9 9
Lines 888 897 +9
==========================================
+ Hits 853 862 +9
Misses 35 35 ☔ View full report in Codecov by Sentry. |
DiamondJoseph
force-pushed
the
frame-duration
branch
from
6d17ff5 to
51bee05
Compare
DiamondJoseph
added a commit
to DiamondLightSource/dodal
that referenced
this pull request
Jan 29, 2024
- bluesky/scanspec#93 - Currently unused by plans
DiamondJoseph
added a commit
to DiamondLightSource/dodal
that referenced
this pull request
Jan 29, 2024
- bluesky/scanspec#93 - Currently unused by plans
coretl
approved these changes
Jan 31, 2024
coretl
reviewed
Jan 31, 2024
DiamondJoseph
added a commit
to DiamondLightSource/dodal
that referenced
this pull request
Feb 6, 2024
- bluesky/scanspec#93 - Currently unused by plans
…i22-bluesky) to ScanSpec
DiamondJoseph
force-pushed
the
frame-duration
branch
from
51bee05 to
cb848f3
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function was added during i22 plan development, but appears to not be used in any current i22 plans.
If it is generally useful behaviour for a ScanSpec, it should probably exist in this repository rather than in dodal.