Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures #155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix CI failures #155

wants to merge 3 commits into from

Conversation

tpoliaw
Copy link

@tpoliaw tpoliaw commented Jan 24, 2025

Not sure why the generated schema has changed but tests were failing on a clean
checkout of main.

  • Update schema to fix test
  • Update typing to make pyright quiet
  • Reformat so ruff stops complaining

Instructions to reviewer on how to test:

  1. tox -e pre-commit,type-checking,tests
  2. Everything passes

Checks for reviewer

  • Would the PR title make sense to a user on a set of release notes

@tpoliaw
Copy link
Author

tpoliaw commented Jan 24, 2025

Change seems to be

                        'type': {
                            'const': 'Zip',
                            'default': 'Zip',
  +                         'enum': [
  +                             'Zip',
  +                         ],
                            'title': 'Type',
                            'type': 'string',
                        },

in various blocks throughout the schema with varying values in the new list

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 95.74%. Comparing base (9b20663) to head (dc7e8ec).

Files with missing lines Patch % Lines
src/scanspec/plot.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #155   +/-   ##
=======================================
  Coverage   95.74%   95.74%           
=======================================
  Files           9        9           
  Lines         940      940           
=======================================
  Hits          900      900           
  Misses         40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

A handful have been ignored where they appear to be from matplotlib not
being typed. The rest were by relaxing requirements for np.float64
instead of np.floating[Any].
@tpoliaw tpoliaw changed the title Update schema.json Fix CI failures Jan 24, 2025
@tpoliaw
Copy link
Author

tpoliaw commented Jan 24, 2025

Change from np.float64 to np.floating[Any] is caused by np.linspace returning np.NDArray[np.floating[Any]]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant