Send prevs on firehose #3449
Open
Send prevs on firehose #3449
+861
−153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }, | ||
| "prev": { | ||
| "type": "cid-link", | ||
| "description": "EXPERIMENTAL. For deletes and updates, the CID of the previous record. For creates, undefined." |
There was a problem hiding this comment.
Should we use a nullable to be able to determine if the implementation supports this or not ?
There was a problem hiding this comment.
I had the same thought about detecting support. Daniel pointed out that we don't need to worry about that yet for the experimental phase. The tricky part here will be that we want to avoid optional, nullable fields.
There was a problem hiding this comment.
just to note, nullable and optional combined is a no-go (for golang), and that is especially relevant for these wire protocol details.
|
to cross-reference, I have a similar set of Lexicon changes proposed in this PR: #3391 |
This was referenced Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an experimental field
subscribeReposcommit ops which includes the cid of theprevrecord in the case of updates/deletes.This is intended for testing of a new sync semantic that allows firehose consumers to do fully authenticated sync without keeping around a repo store.
Note on the implementation: I moved ops into the
CommitDatabecause they need a reference to theprevwhich can only be gotten from the transactional update of the user's repository, not in the "write preparation" step since two writes at the same time will cause one transaction to fail and replay while write preparation happens outside of the transaction.