Gixing websocket subscriptions for signatures and slot #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -18,7 +18,7 @@ solana-sdk = { workspace = true } | |||
| solana-streamer = { workspace = true } | |||
| solana-transaction-status = { workspace = true } | |||
| solana-net-utils = { workspace = true } | |||
| rustls = { workspace = true, features = ["dangerous_configuration"]} | |||
There was a problem hiding this comment.
why did you remove that?
There was a problem hiding this comment.
not needed.
tests/client.test.ts
Outdated
| @@ -24,19 +24,61 @@ function createTransaction(): Transaction { | |||
| return transaction; | |||
| } | |||
|
|
|||
| // test('send and confrim with websockets', async () => { | |||
There was a problem hiding this comment.
what is that commented code?
There was a problem hiding this comment.
will remove it
| expect(Object.keys(leaderSchedule).length > 0); | ||
| } | ||
| }); | ||
| // test('get epoch info', async () => { |
There was a problem hiding this comment.
commented code - decide what to do with it
There was a problem hiding this comment.
Not needed really
grooviegermanikus
previously approved these changes
Jun 28, 2024
godmodegalactus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating signatures for few methods,
Fixing websockets signatures.
Removing unwanted tests