-
Notifications
You must be signed in to change notification settings - Fork 635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check all required keys #1489
Conversation
Made a change because it wasn't playing nice with providers like openai that have a combo of optional and required params
This means:
The condition |
@@ -3419,7 +3419,7 @@ dependencies = [ | |||
"cfg-if", | |||
"proc-macro2", | |||
"quote", | |||
"syn 2.0.96", | |||
"syn 2.0.98", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this Cargo.lock change related to the ui changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks like an auto update after run just run-ui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i have no idea -- i pulled main and then switched to the branch and then updated the ui and when committing saw cargo had changes too... i am confident that cargo.lock was not modified when i switched to the branch, and i think it may have happened during just run-ui
during the cargo build
step
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a minor comment about the Cargo.lock
To check whether it is required key, we should check the required_keys map instead of default_keys as some keys are required and do have default value. Right now users cannot launch with ollama
Before:

After:
