Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the derivation path on all keys #276

Merged
merged 5 commits into from
Mar 5, 2025
Merged

Fix the derivation path on all keys #276

merged 5 commits into from
Mar 5, 2025

Conversation

dangershony
Copy link
Member

This PR brings the code on how we derive keys to be as expected in the specification
#269

Once this PR is pushed the BCIP will be updated.
https://github.com/block-core/bcips/blob/main/bcip-0005.md#key-derivation-path

…the nostr accounts
@DavidGershony DavidGershony self-requested a review March 5, 2025 13:54
DavidGershony
DavidGershony previously approved these changes Mar 5, 2025
Copy link
Collaborator

@DavidGershony DavidGershony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good, with minor comments.

@dangershony dangershony merged commit 191c3e2 into main Mar 5, 2025
3 checks passed
@dangershony dangershony deleted the derivation-fix branch March 5, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants