Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blackpill/readme: Update to describe need for "on_carrier_board" option #2067

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

sidprice
Copy link
Contributor

This PR updates the Blackpill-F4 readme to describe the need for the "on_carrier_board" bujild option.

Your checklist for this pull request

Closing issues

None

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There looks to be one typo in the change and one in the commit message. With those addressed, we're happy to approve this and get this merged.

@@ -50,6 +50,10 @@ meson setup build --cross-file=cross-file/blackpill-xxxxxx.ini -Dbmd_bootloader=

Note: While the above command uses the 'build' directory, the name used is arbitrary, meaning, should a user wish to have multiple platforms built, they may use a more descriptive folder name.

Also Note: If the bootloader and firmware are going to be built for a Blackpill connected to a "Blackpill Carrier," the above
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a typo - ," instead of ", at the end of "Blackpill Carrier",?

@dragonmux dragonmux added this to the v2.0 release milestone Jan 31, 2025
@dragonmux dragonmux added Bug Confirmed bug Documentation Project documentation Foreign Host Board Non Native hardware to runing Black Magic firmware on labels Jan 31, 2025
@sidprice sidprice force-pushed the Update_blackpill_readme branch from b3c3148 to 574c2ac Compare January 31, 2025 15:26
@sidprice sidprice force-pushed the Update_blackpill_readme branch from 574c2ac to b9fd77e Compare January 31, 2025 15:30
Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging. Thank you for the contribution!

@dragonmux dragonmux merged commit b9fd77e into blackmagic-debug:main Jan 31, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Confirmed bug Documentation Project documentation Foreign Host Board Non Native hardware to runing Black Magic firmware on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants