Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackpill/platform: Correct the condiitonal compilation symbol to initialize the bootloader LED pin. #2066

Merged

Conversation

sidprice
Copy link
Contributor

This PR corrects a naming issue with the Blackpill-F4 platform.

The bootloader LED pin was not being setup.

Your checklist for this pull request

Closing issues

None

Copy link
Member

@dragonmux dragonmux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well spotted - merging. Thank you for the contribution!

@dragonmux dragonmux added this to the v2.0 release milestone Jan 31, 2025
@dragonmux dragonmux added Bug Confirmed bug BMP Firmware Black Magic Probe Firmware (not PC hosted software) Foreign Host Board Non Native hardware to runing Black Magic firmware on labels Jan 31, 2025
@sidprice sidprice force-pushed the fix_blackpill_f4_bootloader_pin_init branch from 9d6b35e to 0261585 Compare January 31, 2025 15:15
@dragonmux dragonmux merged commit 0261585 into blackmagic-debug:main Jan 31, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BMP Firmware Black Magic Probe Firmware (not PC hosted software) Bug Confirmed bug Foreign Host Board Non Native hardware to runing Black Magic firmware on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants